Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configuration): use DTO in controller #936

Merged

Conversation

garrappachc
Copy link
Member

No description provided.

@garrappachc garrappachc added the fix A fix to an issue label Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #936 (0f817a7) into master (292037b) will increase coverage by 0.00%.
The diff coverage is 96.29%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #936   +/-   ##
=======================================
  Coverage   93.62%   93.63%           
=======================================
  Files         118      120    +2     
  Lines        2590     2609   +19     
  Branches      270      270           
=======================================
+ Hits         2425     2443   +18     
- Misses        164      165    +1     
  Partials        1        1           
Impacted Files Coverage Δ
src/configuration/dto/default-player-skill.ts 90.00% <90.00%> (ø)
...figuration/controllers/configuration.controller.ts 100.00% <100.00%> (ø)
src/configuration/dto/whitelist-id.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 292037b...0f817a7. Read the comment docs.

@garrappachc garrappachc merged commit ba39434 into tf2pickup-org:master Mar 19, 2021
@garrappachc garrappachc deleted the configuration-controller-dtos branch March 24, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix to an issue
Development

Successfully merging this pull request may close these issues.

1 participant